Open lyao-77 opened 1 year ago
Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.
Trivial Change
Code
Architecture
Hi @dmitrii-ubskii @alexjpwalker Can you take a look at this PR? Thanks!
Do you mind showing some examples of how/why these changes are to be used please?
Hi @flyingsilverfin , I think the entry_point
field is only a filed for setuptools
. We would like to add it because when we assemble our package using setuptools
directly, we use this field.
Regarding the other change, the use case is that we used this rule to assemble one of our internal python library, and then use it in another project. We met some issues during import
and realized that when bazel load it's dependency, it will generate a __init__.py
for each module with the following content:
"# path manipulation added by bazelbuild/rules_python to support namespace pkgs. path = import('pkgutil').extend_path(path, name) "
However, since we hardcoded an empty __init__.py
in current implementation during packaging, it will interrupt how bazel works and the import
won't work
Hi, thanks for the contribution! By way of update (and managing expectations), unfortunately we don't currently have the resources to test this code in detail and I don't have an ETA on that. Please continue to depend on your fork of bazel-distribution
for the time being, apologies for the inconvenience.
+1 for merging this PR into master branch. I am already using this change from PR branch.
What is the goal of this PR?
This PR is to: