Update bazel rule sets and allow python packaging to include generated files

dmikhalin commented 11 months ago

What is the goal of this PR?

We upgrade rule sets rules_python and rules_pkg, and remove unnecessary workarounds related to documentation generation with stardoc.

We also fix python packaging to allow including generated library files. Generated library files for python are automatically put into the bazel-out/.../bin directory and the module can't reach them. We move these files into the module directory.

What are the changes implemented in this PR?

We changed the paths of all files in bazel-out/.../.../**/* to **/*.
We updated the rules_python version to 0.24.0 and replaced deprecated pip_install() with pip_parse().
Update rules_pkg to 0.9.1 and rules_rust to v0.26.0.

vaticle-bot commented 11 months ago

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.

Trivial Change

[ ] This change is trivial and does not require a code or architecture review.

Code

[x] Packages, classes, and methods have a single domain of responsibility.
[x] Packages, classes, and methods are grouped into cohesive and consistent domain model.
[x] The code is canonical and the minimum required to achieve the goal.
[x] Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
[x] Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
[x] The code is algorithmically efficient and scalable for the whole application.

Architecture

[x] Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
[x] Any required build and release automations are updated and/or implemented.
[x] Any new components follows a consistent style with respect to the pre-existing codebase.
[x] The architecture intuitively reflects the application domain, and is easy to understand.
[x] The architecture has a well-defined hierarchy of encapsulated components.
[x] The architecture is extensible and scalable.

flyingsilverfin commented 10 months ago

We have rolled in the changes from https://github.com/vaticle/bazel-distribution/pull/378 into this PR, except the nodejs permissioning error fix, which should be easy enough to re-create.

Comments in that PR describe some of the upgrades and changes, especially related to stardoc.

vaticle / bazel-distribution