vaticle / bazel-distribution

Bazel rules for assembling and deploying software distributions (see @vaticle for usage example)
https://bazel.build
Apache License 2.0
155 stars 53 forks source link

Artifact deployment: use version_file, fix version validation #401

Closed dmitrii-ubskii closed 5 months ago

dmitrii-ubskii commented 5 months ago

What is the goal of this PR?

We fix two issues in artifact deployment rules:

  1. The version_file argument was ignored in favor of the version environment variable. The behavior is now in line with the rest of rulesi n this repository.
  2. Snapshot version validation was overly strict and only permitted versions that were exactly SHA1. We now require that a snapshot artifact version ends in SHA1.
vaticle-bot commented 5 months ago

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

Code

Architecture