grabl
commented
1 year ago PR Review Checklist
Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.
Code
- [ ] Packages, classes, and methods have a single domain of responsibility.
- [ ] Packages, classes, and methods are grouped into cohesive and consistent domain model.
- [ ] The code is canonical and the minimum required to achieve the goal.
- [ ] Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
- [ ] Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
- [ ] The code is algorithmically efficient and scalable for the whole application.
Architecture
- [ ] Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
- [ ] Any required build and release automations are updated and/or implemented.
- [ ] Any new components follows a consistent style with respect to the pre-existing codebase.
- [ ] The architecture intuitively reflects the application domain, and is easy to understand.
- [ ] The architecture has a well-defined hierarchy of encapsulated components.
- [ ] The architecture is extensible and scalable.
flyingsilverfin
What is the goal of this PR?
We add back the Neo4J benchmark to allow comparisons between TypeDB and Neo4j. We also comment out the 3-node cluster tests, and keep only Neo4j, TypeDB, and TypeDB Cluster with 1 node as our baseline. Factory-tracing can also be enabled via the factory-tracing arguments to benchmark, once the tracing SSL issues are resolved.
What are the changes implemented in this PR?