search

vaticle / typedb-common

TypeDB Common Libraries and Scripts
GNU Affero General Public License v3.0
7 stars 15 forks source link

Remove TypeDB runner --debug switch #70

Open lolski opened 3 years ago

lolski commented 3 years ago

TypeDB can be ran in debug mode, in which it'll run RocksDB's dev release, if it is available.

The detection of the debug flag is done in bash since we need to configure the classpath before TypeDB is started. It is complicated if you want do it in TypeDB, after bootup.

However, we may decide that the --debug flag is not critical and/or RocksDB is replaced or never used in dev mode anyway, so we can remove the flag.

lolski commented 3 years ago

[Triaged] @haikalpribadi I am moving it to the backlog since this refactor is not critical

flyingsilverfin commented 1 year ago

After further discussion, we have agreed that we should keep the --debug flag.

In the ideal scenario, the --debug flag will switch on the dev JAR that contains debugging symbols of the storage library (eg. RocksDB). If we stick with just that behaviour, we should rename it to --devDependencies or --devStorage, etc.

Otherwise, --debug could also take a level --debug=2 which will automatically enable some level of verbose logging throughout the codebase.