Update docker run instructions to docker create & docker start instead

krishnangovindraj commented 2 weeks ago

What is the goal of this PR?

Update instructions for using the TypeDB core & cloud docker images to be more explicit about mounting volumes.

Update TypeDB core docker command to create a named docker volume & mount server/data on it.
Update TypeDB Cloud docker command to create a volume each for data, replication and user.

vaticle-bot commented 2 weeks ago

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.

Trivial Change

Code

[ ] Packages, classes, and methods have a single domain of responsibility.
[ ] Packages, classes, and methods are grouped into cohesive and consistent domain model.
[ ] The code is canonical and the minimum required to achieve the goal.
[ ] Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
[ ] Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
[ ] The code is algorithmically efficient and scalable for the whole application.

Architecture

[ ] Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
[ ] Any required build and release automations are updated and/or implemented.
[ ] Any new components follows a consistent style with respect to the pre-existing codebase.
[ ] The architecture intuitively reflects the application domain, and is easy to understand.
[ ] The architecture has a well-defined hierarchy of encapsulated components.
[ ] The architecture is extensible and scalable.

flyingsilverfin commented 2 weeks ago

Looks good to me, but @alexjpwalker please confirm the formatting, correct branch, etc please!