search

vaticle / typedb-studio

TypeDB Studio (IDE)
https://typedb.com
Mozilla Public License 2.0
186 stars 43 forks source link

TypeDB-Studio 2.14.2-1_amd64.deb - binary installs with 'TypeDB Studio' name #696

Open pdurusau opened 1 year ago

pdurusau commented 1 year ago

Description

TypeDB-Studio 2.14.2-1_amd64.deb - binary installs with 'TypeDB Studio' name, on Debian, that requires escaping the space to run the binary, thus: ./TypeDB\ Studio.

Environment

  1. TypeDB version: 2.14.2
  2. OS of TypeDB server: Debian
  3. Studio version: 2.14.2-1_amd64.deb
  4. OS of Studio: Debian
  5. Other environment details: None.

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. dpkg -i typedb-studio_2.14.2-1_amd64.deb
  2. cd /opt/typedb-studio/bin
  3. ls
  4. 'TypeDB Studio'*

Expected Output

TypeDB-Studio*

Actual Output

'TypeDB Studio'*

Additional information

Should I open a separate issue on /opt/typedb-studio/bin NOT being automatically added to the user's path?

(Thanks for all the hard work!)

alexjpwalker commented 1 year ago

Thanks for the report @pdurusau !

The Debian distribution (like the Windows and MacOS distributions) is compiled with jpackage --name="TypeDB Studio": see https://docs.oracle.com/en/java/javase/14/docs/specs/man/jpackage.html. This results in the distributed image being named TypeDB Studio. When installed on a machine with an application menu, it shows up as TypeDB Studio, as opposed to being listed as typedb-studio.

Is this counter to the industry standards for desktop GUI applications on Debian-based systems?

jamesreprise commented 1 year ago

See https://github.com/vaticle/typedb-studio/issues/630.

As in the above issue, I think we should provide a symlink named typedb-studio and ensure it is in the user's PATH at least.

pdurusau commented 1 year ago

Thanks for the report @pdurusau !

The Debian distribution (like the Windows and MacOS distributions) is compiled with jpackage --name="TypeDB Studio": see https://docs.oracle.com/en/java/javase/14/docs/specs/man/jpackage.html. This results in the distributed image being named TypeDB Studio. When installed on a machine with an application menu, it shows up as TypeDB Studio, as opposed to being listed as typedb-studio.

Is this counter to the industry standards for desktop GUI applications on Debian-based systems?

Sorry! I never thought about using the GUI even though it reports (now that I look) TypeDB Studio. I defaulted to the command line and that's how I discovered it wasn't in my path. (It works from the menu item.) Thanks for the quick response!