Fix Role resolution in rules

[krishnangovindraj]

Usage and product changes

Fixes how rules resolve roles, fixing validation that types referenced in rules cannot be deleted.

Implementation

• Translates scoped role name as it occurs in the rule to the actual scoped name of the role (i.e., from inheritor:role to declarer:role) when computing which types occur in the rule.

[vaticle-bot]

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.

---

Trivial Change

• [ ] This change is trivial and does not require a code or architecture review.

Code

• [ ] Packages, classes, and methods have a single domain of responsibility.
• [ ] Packages, classes, and methods are grouped into cohesive and consistent domain model.
• [ ] The code is canonical and the minimum required to achieve the goal.
• [ ] Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
• [ ] Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
• [ ] The code is algorithmically efficient and scalable for the whole application.

Architecture

• [ ] Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
• [ ] Any required build and release automations are updated and/or implemented.
• [ ] Any new components follows a consistent style with respect to the pre-existing codebase.
• [ ] The architecture intuitively reflects the application domain, and is easy to understand.
• [ ] The architecture has a well-defined hierarchy of encapsulated components.
• [ ] The architecture is extensible and scalable.

[krishnangovindraj]

The bug this fixes would be caught by type-inference at commit time. Further, this makes the validation for the same bug caused byset_supertype more complicated if we want to be consistent with when we flag unsatisfiable rules.

[krishnangovindraj]

I forget type-inference automatically downcasts to subtypes based on their relates/owns/plays constraints. This, role types cannot always be uniquely resolved.