vaticle / typedb

TypeDB: the polymorphic database powered by types
https://typedb.com
Mozilla Public License 2.0
3.72k stars 338 forks source link

Fix bug when overriding committed role-types with newly defined role-types #6984

Closed krishnangovindraj closed 4 months ago

krishnangovindraj commented 4 months ago

Usage and product changes

Fixes a bug which creates an invalid override when a committed role-type is overridden with a newly defined role-type.

Implementation

Updates TypeEdgeImpl.Persisted to treat overrides as TypeEdgeImpl.Buffered does - Writing to the transaction is delayed to the commit() method, by when the overridden vertex will have been translated.

fixes #6985

vaticle-bot commented 4 months ago

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

Code

Architecture

flyingsilverfin commented 4 months ago

Rebase, update dependency, and let's merge this one