search

vatis-project / vatis

Virtual Automated ATIS Generator for VATSIM
https://docs.vatis.clowd.io
GNU General Public License v3.0
36 stars 16 forks source link

Cloud altitude /// is 0ft instead of undetermined or below station level + omits convective type #138

Closed Phil7789 closed 1 year ago

Phil7789 commented 1 year ago

With a cloud altitude of /// the spoken ATIS is "0ft" but should be "undetermined" or "below station level" instead. If a convective types follows the type is omitted.

e.g. FEW///TCU is spoken as "FEW clouds at 0" but should rather be e.g. "FEW clouds undetermined towering cumulus" and text could "FEW undetermined TCU"

Was 52184a2 an attempt to fix?

justinshannon commented 1 year ago

The next update will include two new formatting fields that will allow you to customize the text and voice string for an undetermined cloud layer altitude (and fixes the missing convective type).

Phil7789 commented 1 year ago

That is what I call a quick fix. Thank you very much. Now I need bad enough weather to test it, but it looks great :)

Btw the missing convective type was probably missing because {convective} is not default with FEW. Why this isn't default I don't know, I've added it and will also test it.

justinshannon commented 1 year ago

There was actually a bug in the METAR parsing that broke the convective type if the altitude was undetermined. It wouldn’t have worked even if you added the {convective} variable.