store duplicate functions in different .py files inside of a single .py file

vatlab / sos

SoS workflow system for daily data analysis

http://vatlab.github.io/sos-docs

BSD 3-Clause "New" or "Revised" License

274 stars 45 forks source link

Closed jenningsje closed 2 years ago

jenningsje commented 2 years ago

These files are sos/docker/client.py and sos/singularity/client.py.

Likewise the duplicate functions are as follows: _is_image_avail(self, image) and _run_cmd(self, cmd, **kwargs).

These are both stored within imports.py which lies in the directories /sos/src/sos/docker and /sos/src/sos/singularity respectively.

BoPeng commented 2 years ago

PRs should have clear and single purposes. Please

Create a separate PR for adding all warnings.
Create one PR with the removal of one warning (so that we know what the warnings are about) and the fixes.

I am not sure which warnings you are trying to suppress, but the changes are big and not entirely safe. I would start from simpler ones.