vatlab / sos

SoS workflow system for daily data analysis
http://vatlab.github.io/sos-docs
BSD 3-Clause "New" or "Revised" License
274 stars 45 forks source link

Inconsistent behavior of R_library() between released version 0.22.7 and current github 0.22.8 #1492

Closed gaow closed 2 years ago

gaow commented 2 years ago

I had an issue with R_library() which I pinpoint to this behavior:

Expected, in released version of SoS

>>> from sos.pattern import glob_wildcards
>>> glob_wildcards('{repo}@{pkg}', ['dscrutils@stephenslab/dsc/dscrutils'])
{'repo': ['dscrutils'], 'pkg': ['stephenslab/dsc/dscrutils']}
>>> from sos import __version__
>>> print(__version__)
0.22.7

Unexpected, in current github master branch

>>> from sos.pattern import glob_wildcards
>>> glob_wildcards('{repo}@{pkg}', ['dscrutils@stephenslab/dsc/dscrutils'])
{'repo': [], 'pkg': []}
>>> from sos import __version__
>>> print(__version__)
0.22.8
>>> 

From github blame records I dont think this change is intentional. So it should be a bug?

BoPeng commented 2 years ago

Sorry, I failed to identify a regression bug made by my programmer. It has been fixed.

BoPeng commented 2 years ago

sos test suite is not working now due to #1371. The problem is that the "cleaner" tests uses execute_workflow function call instead of sos run command, so failed tests will fail to release file handlers etc, causing the next tests to fail. This is very tricky to fix and prevents me from detecting such problems.

Fixing the test suite should be a real priority now.