vatro / svelthree

Create three.js content using Svelte components.
https://svelthree.dev
MIT License
482 stars 15 forks source link

Check / polish setting lights target #136

Closed vatro closed 1 year ago

vatro commented 2 years ago

Test extensively & refactor, this has to bulletproof for next.1

Noticed (issues) during testing:


Test: (twice) set target to a component reference + set target to false

Test: (twice) set target to component's three.js instance reference + set target to false

Test: (twice) set target to a premade / manually added three.js instance + set target to false

Test: (twice) set target to a nested (grouped) component reference + set target to false

Test: (twice) set target to an object inside a complex loaded GLTF + set target to false

vatro commented 1 year ago

looking good! ✔️ Also checked after related recent fixes: