`Scene`: verify (delete?) confusing comment / `scene.userData.animations` usage

vatro / svelthree

Create three.js content using Svelte components.

https://svelthree.dev

MIT License

485 stars 15 forks source link

`Scene`: verify (delete?) confusing comment / `scene.userData.animations` usage #94

Closed vatro closed 1 year ago

vatro commented 2 years ago

What was the exact intention behind adding scene.userData.animations (even if it's not being used)?
Has something similar been implemented instead?

https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/Scene.svelte#L191-L194

https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/Scene.svelte#L252-L255

vatro commented 1 year ago

I guess my intention was to be able control / check / manipulate all animations inside a scene via the Scene instance, but that's just a guess. I'll delete it since *.userData.animations isn't used / implemented anywhere.