Add Label Search - Githubissues

vatsalsinghkv / easy-fix

Discover the ideal platform to find easily manageable issues, designed to inspire and encourage individuals to initiate their contributions to the open source community.

https://easy-fix.vercel.app

50 stars 34 forks source link

Add Label Search #51

Closed newtoallofthis123 closed 3 weeks ago

newtoallofthis123 commented 1 year ago

This commit modifies the reducers to use label search as well.

It works well in most cases, however, there are two major issues I need help with.

The Reducers send more requests for some reason
The application crashes when it github returns an error

I am putting this pr in review. Any and all help is appreciated. I am not that good with tsx, but I tried my best. @vatsalsinghkv can you please get the help this pr needs?

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @vatsalsinghkv on Vercel.

@vatsalsinghkv first needs to authorize it.

fekete965 commented 1 year ago

@newtoallofthis123 would you be able to run prettier on the codebase, please?

newtoallofthis123 commented 1 year ago

Sure!

fekete965 commented 1 year ago

Sure!

I just noticed that some mult-line imports changed into a single line and I am not sure if there is something with the Prettier config as on my side locally it broke it into multiple lines 🤔 Thank you for checking this for me :)

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
easy-fix	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2023 4:27pm

vatsalsinghkv commented 1 year ago

@fekete965 @newtoallofthis123 can you guys check the preview? if its working correctly?

newtoallofthis123 commented 1 year ago

There seems to be some sort of a problem....I think it is related to the state management....will look into it...any help appreciated :)

fekete965 commented 1 year ago

@vatsalsinghkv @newtoallofthis123 there is an error in the console: Cannot read properties of undefined (reading 'join').

I think we try to use .join on an optional value. It could be fixed with the optional chaining (?.join)

I can take a look at the issue later on if still needed.

vatsalsinghkv commented 1 year ago

@newtoallofthis123 Can u pull the changes and resolve conflicts

newtoallofthis123 commented 1 year ago

Sure! Will do

vatsalsinghkv commented 1 year ago

@newtoallofthis123 sorry for reviewing it late, I finally able to run it locally, you've added a text search bar for search by label, but we wanted to have pre-defined buttons for label, for example