Closed marvk closed 3 years ago
Speaking of "countries with outdated names" - the list is missing "North Macedonia" (former FYROM, or just "Macedonia"), with code "LW".
@ChrisXPP FYROM
is in the current list:
However, I agree this falls in the category of "Contries with outdated names".
BKPR is a valid designator, it originates due to the special political situation in the region, but this code has been in use since many years (LYPR however is not used, or very very seldom)
I compiled a list of (possible) changes for the above mentioned country names.
Note that I completely removed the "USA|PK|" line since the (correct) entry for the Marshall Islands is already included.
Just some thoughts about the airport list, before creating a PR...
Canada: the prefix definition needs to be amended by CJ, CK, CL, CN, CP and CS to fetch remaining ICAO codes
Kosovo: needs to be added to fetch ICAO codes starting with BK
Equatorial Guinea: needs to be added to fetch ICAO codes starting with FG
British Indian Ocean Territory: needs to be added to fetch ICAO codes starting with FJ
Sao Tome and Principe: needs to be added to fetch ICAO codes starting with FP
Palestine: needs to be added to fetch ICAO codes starting with LV
Turks and Caicos Islands: needs to be added to fetch ICAO codes starting with MB
Wallis and Futuna: needs to be added to fetch ICAO codes starting with NL
United States/Alaska: the prefix definition needs to be amended by PC to fetch remaining ICAO codes
Bhutan: needs to be added to fetch ICAO codes starting with VQ
Brazil: the prefix definition needs to be amended by SJ to fetch remaining ICAO codes
Russia: the prefix definition needs to be amended by XK and XM to fetch remaining ICAO codes
helipads M666 and M820: these are no valid ICAO designators
Rampart airport, Alaska: currently has the code PRMP, but that's most probably wrong and should rather be PFMP - see here: https://www.airnav.com/airport/PFMP
heliports/helipads starting with Q: I could not find any documentation regarding the existence of these codes
airports Z10T and Z10W: these are no valid ICAO designators
There are 206 airports with an unknown ICAO country prefix in the dataset. I have compiled the list of ICAO airport code prefixes from the Wikipedia article on ICAO airport codes into a format similar to the one used in the dataset and created a diff so that it is easier to discern which codes are missing or outdated.
I have not adjusted the country names, which I think might need some work as well. However, the names from the Wikipedia article are inconsistend in their own right (Using both country names and official state names), so they should not be used without further cleaning up.
Also, be advised that the russian pseudo-icao-codes beginning with
X
are missing at the moment.As a sidenote, to be able to contribute PRs, do I need to be part of my ARTCC in an executive capacity or does a simple member status suffice? If a simple member status suffices, I can get on that and following my verification, clean this up and submit these changes as a proper PR.
Inconsistent dividers when one prefix covers multiple countries (
and
vs-
)https://github.com/vatsimnetwork/vatspy-data-project/blob/f840d74eee3032cc77da5116dbd4563aad6009e6/VATSpy.dat#L189
https://github.com/vatsimnetwork/vatspy-data-project/blob/f840d74eee3032cc77da5116dbd4563aad6009e6/VATSpy.dat#L252
Non-english country names
https://github.com/vatsimnetwork/vatspy-data-project/blob/f840d74eee3032cc77da5116dbd4563aad6009e6/VATSpy.dat#L103
Contries with outdated names
https://github.com/vatsimnetwork/vatspy-data-project/blob/f840d74eee3032cc77da5116dbd4563aad6009e6/VATSpy.dat#L247
Prefixes with distinct names
https://github.com/vatsimnetwork/vatspy-data-project/blob/f840d74eee3032cc77da5116dbd4563aad6009e6/VATSpy.dat#L169
https://github.com/vatsimnetwork/vatspy-data-project/blob/f840d74eee3032cc77da5116dbd4563aad6009e6/VATSpy.dat#L295
Airports with unknown prefixes