search

vaughnbetz / COFFE

38 stars 25 forks source link

Adding support for mode signal during Primetime #31

Closed aman26kbm closed 4 years ago

aman26kbm commented 4 years ago

Dr. Betz,

I was doing some COFFE experiments and I saw that providing a value to "mode_signal" configuration variable in the hardblock settings file was not working. I saw that that was because a missing couple of lines in utils.py.

This is how it was in the original COFFE code, before my changes from last month. My guess is that it was like this because this feature isn't getting tested in any of the existing tests because in the hbsettings.txt file, the mode_signal is commented out (https://github.com/vaughnbetz/COFFE/blob/master/input_files/hbsettings.txt#L136).

Anyway, I fixed it locally and I tested it and it works now. I thought I'll submit a push request for this.

Thanks, Aman

vaughnbetz commented 4 years ago

Looks good; thanks Aman.

aman26kbm commented 4 years ago

Np :)