search

vault-development / react-native-svg-uri

Render SVG images in React Native from an URL or static file
849 stars 334 forks source link

support expo #111

Closed gaboelnuevo closed 4 years ago

ezhlobo commented 6 years ago

@vault-development hey, can we think about these changes? What do you need to make it merged?

gaboelnuevo commented 6 years ago

I found an issue with current React-Native versions please test it before

ezhlobo commented 6 years ago

@gaboelnuevo could you provide more details, please? I'm going to use this library.

gaboelnuevo commented 6 years ago

@ezhlobo I encounter a error while testing in react-native ^0.52.2 but in expo works very well

gaboelnuevo commented 6 years ago

I think that some configurations of babel presets throw an error when required failed.

joao-conde commented 5 years ago

How about merging this? Seems to be properly working?

nathsimpson commented 5 years ago

When will this be merged???

sandersjj commented 5 years ago

I can confirm that this fix works for me.

keeth commented 5 years ago

confirmed. please merge.

gaboelnuevo commented 4 years ago

In new versions of Expo this commit is unnecessary and deprecated. (SDK >= v33.0.0)

msand commented 4 years ago

You can use SvgUri from react-native-svg nowadays instead. No need for react-native-svg-uri.