vault-development / react-native-svg-uri

Render SVG images in React Native from an URL or static file
850 stars 334 forks source link

Hook based component refactor and dependency update #207

Open rolandtreiber opened 3 years ago

rolandtreiber commented 3 years ago

Hi I tried to install this package but ran into a peer dependency issue whereas npm was complaining about my installed react-native-svg being quite a few major versions ahead of the required by this package. (5 <> 12) So I first wanted to find out if it would break with the newest version. -> it did not. Then react native threw a warning about the - since renamed - componentWillReceiveProps function that led me to refactor the main component to use hooks instead of being class based. Obviously tested it thoroughly.

Please note that this is my first ever open source contribution, so if you don't like something, pls be gentle :)