Update to re-render when svgXmlData and fill props change

vault-development / react-native-svg-uri

Render SVG images in React Native from an URL or static file

851 stars 335 forks source link

Update to re-render when svgXmlData and fill props change #30

Closed ruifreitas closed 7 years ago

ruifreitas commented 7 years ago

This PR does the following:

It updates the component to re-render when the svgXmlData and fill props change.
Fix the svg width and height attrs missing.

SandroMachado commented 7 years ago

@matc4 any plans to merge this PR?

matc4 commented 7 years ago

Hello @SandroMachado , I have a doubt with this PR:

It updates the component to re-render when the svgXmlData and fill props change.

Is not working already in this way?

SandroMachado commented 7 years ago

Hi @matc4,

unfortunately not. If we change the svgXmlData or the fill prop after the instantiation of the component, it does not change it. We need to update the state in the method componentWillReceiveProps.

Regards

srounce commented 7 years ago

Any update on this PR?

SandroMachado commented 7 years ago

@matc4 sorry to bother you again but can you please take a look at this PR.

beilunyang commented 7 years ago

I also meet the bug, please merge this PR...

matc4 commented 7 years ago

Thanks @ruifreitas !