search

vault-development / react-native-svg-uri

Render SVG images in React Native from an URL or static file
849 stars 334 forks source link

Added prop-types node module #78

Closed prscX closed 6 years ago

prscX commented 6 years ago

React as deprecated importing of PropTypes from react:

import React, {Component, PropTypes} from "react";

They have created a separate node module prop-type for the same:

import PropTypes from 'prop-types'

In ReactNative >=0.49.0 it is throwing exception due to which app is not working

Can you please approve this merge request, so that in next release onwards we can get the fix for the same

Please let me know in case any discussion is needed

matc4 commented 6 years ago

Hello @prscX ! , is no need to add prop-types to package.json?

prscX commented 6 years ago

Hi @matc4

Both React and ReactNative has mentioned prop-types as their dependencies:

I have personally tested this and it is working as expected, however in case someone wants to use this library excluding React then it will not work

Let me know in case I have to add prop-types as dependency

matc4 commented 6 years ago

Perfect then!