search

vault-development / react-native-svg-uri

Render SVG images in React Native from an URL or static file
849 stars 334 forks source link

Comments in SVG files #97

Closed danielreuterwall closed 6 years ago

danielreuterwall commented 6 years ago

Hi,

In some of my SVG files I have comments added. If I add them with react-native-svg-uri I the a "Raw text..." error. I have a fix for it in my fork that works for me, 1eb99cb0ad08e9f18f6a4de96303719310d49454. what do you think @matc4? Should I create a pull request for it?

Cheers, Daniel

danielreuterwall commented 6 years ago

@matc4 Any thoughts on this?

matc4 commented 6 years ago

@danielreuterwall Hello Daniel, i think is a good idea

skozin commented 6 years ago

This seems like a duplicate of #112. Or, more precise, #112 is a duplicate of this issue :) There is a PR that fixes it: #113.

danielreuterwall commented 6 years ago

Yep, looks like the issue. Was a bit late with my PR, great that it's being solved anyhow.