Refreshing wallet outputs produces very long URIs

vault713 / wallet713

A wallet that makes it easy to send, store, and swap Grin.

Apache License 2.0

196 stars 74 forks source link

Refreshing wallet outputs produces very long URIs #164

Closed NotMrPotter closed 5 years ago

NotMrPotter commented 5 years ago

During output refreshes, wallet713 currently queries a Grin node up to 200 IDs at a time via. HTTP GET. This can be problematic with proxies or load balancers (i.e. nginx) in the mix, due to the extreme length of the query's URI.

If you're open to it, I would like to offer a small PR that restricts these queries down to a generally safe sub-8KB maximum.

lehnberg commented 5 years ago

Hi @NotMrPotter, thanks for flagging this and for offering to help! If you submit a PR for this fix in the near future, we'll merge it.

jaspervdm commented 5 years ago

Fixed in #165