search

vault713 / wallet713

A wallet that makes it easy to send, store, and swap Grin.
Apache License 2.0
196 stars 74 forks source link

support receive grin with http ip option #89

Closed wenqingyu closed 5 years ago

wenqingyu commented 5 years ago

Background

There are some mining pools only offer to withdraw grin with HTTP IP rather than Grinbox backed hash address.

Propose feature

As a Wallet713 user, I'd like to receive Grin with HTTP IP option.

bhakterija commented 5 years ago

Same with hotbit.io exchange - seems it only supports http(s) deposits and withdrawals.

ravidio commented 5 years ago

Wallet713 v1.0.1 supports https. The reason we don’t do http is because it is prone to MITM attacks.

bhakterija commented 5 years ago

Wallet713 v1.0.1 supports https. The reason we don’t do http is because it is prone to MITM attacks.

Documentation states that receiving via https is not yet supported. If https receiving is actually available in current version, can you please provide an example of the command? Thanks!

ravidio commented 5 years ago

Sure, see in the doc the section: “Configuring Foreign and Owner APIs”. You need to have the foreign api configured for that to work. Thanks!

ravidio commented 5 years ago

@bhakterija, please note we have tweaked the docs following your comment! It now properly indicates that receiving via http is supported via the foreign API and provides more concrete instructions on how to set this up. Thanks a lot for pointing this out to us, and let me know if you experience any issues please.

bhakterija commented 5 years ago

@bhakterija, please note we have tweaked the docs following your comment! It now properly indicates that receiving via http is supported via the foreign API and provides more concrete instructions on how to set this up. Thanks a lot for pointing this out to us, and let me know if you experience any issues please.

That worked perfectly, thank you!