vauvenal5 / yaga

Nextcloud Yaga - A Nextcloud first gallery app for Android.
https://vauvenal5.github.io/yaga-docs/
GNU General Public License v3.0
137 stars 10 forks source link

App won't load #75

Closed galaxyrun closed 3 years ago

galaxyrun commented 3 years ago

Version: 0.19.1

When I open Yaga and activate Category View, the app freezes.

I think it is because of the synchronization of the images. When flight mode is enabled, the app does not freeze.

Btw grid view does work.

vauvenal5 commented 3 years ago

Hi!

Thanks for reporting. I need some additional information, please:

In general there are a few performance issues regarding the category view which I have not managed to fix yet. It has to do with the way Flutter is calculating if the display is full or not.

luckkmaxx commented 3 years ago

For me the app freezes always while loading/opening the app. Just leave it a few seconds until upper loading bar gones. Then it goes well (no freezes) until I slide down to get updates, so it freezes a few seconds again.

vauvenal5 commented 3 years ago

@luckkmaxx can you provide some additional information:

Thanks!

luckkmaxx commented 3 years ago

@luckkmaxx can you provide some additional information:

  • Which version of the app are you using?
  • Do all view types behave in the same way?
  • Does this happen for all your image locations or do only folders with a lot of images freeze?
  • How many images are you loading?
  • What kind of device do you have?

Thanks!

galaxyrun commented 3 years ago

For me the app freezes always while loading/opening the app. Just leave it a few seconds until upper loading bar gones. Then it goes well (no freezes) until I slide down to get updates, so it freezes a few seconds again.

It's exactly the same for me. I have the newest Update now v.0.21- same issue there

vauvenal5 commented 3 years ago

Could be the sorting algorithm. It is the only time-consuming thing left in the UI thread. Everything else is in a 2nd thread. I will move the list sorting to the background and we will see if it changes anything. :+1:

vauvenal5 commented 3 years ago

Hey! I just published v0.21.5, let me know if this improves the app behavior for you.

luckkmaxx commented 3 years ago

Hey! I just published v0.21.5, let me know if this improves the app behavior for you.

Yes! Now when I open yaga, 3 seconds later the photos are showing and the progress bar works while I can swipe down to older images. No freezes, just a little laggy, but very fine! Thanks, your work seems to be in the right way!

vauvenal5 commented 3 years ago

If you have no objections I will consider this closed for the time being. Further improvements require reworking the whole approach of how files are retrieved, see #80. The main issue boils down to the amount of files and that they are all being loaded at once.

Regarding any lag during scrolling, the Category View (experimental) seems to have a worse performance when handling a lot of files then the Category View. Especially if you have big categories.

galaxyrun commented 3 years ago

Looks like this fixed the problem