Closed LukeVader-IV closed 3 years ago
I am afraid this PR will not work like it is. I assume you did not actually test it?
With the PR like it is currently only the icon in the About dialog would change and nothing else.
The tool I am using for icon generation does not yet support svgs: https://github.com/fluttercommunity/flutter_launcher_icons/issues/20
I suggest the following approach. SVG files will be used to track how the icon looks and also for internal uses directly in the app. For the icon generation process we will need additionally two PNG files for the icon generator.
This means we need the following three SVG files:
We will then create PNG files from them:
All the other icons can be deleted. I agree on proceeding with the icon as provided by the Photos app. :+1:
Edit: Some info for the store graphics: Icon: Transparent PNG or JPEG 512 px by 512 px Up to 1 MB
Feature graphic: PNG or JPEG 1,024 px by 500 px Up to 1 MB
I will then have to switch to using this lib for in app rendering like in the About dialog: https://pub.dev/packages/flutter_svg
Because of this: https://github.com/flutter/flutter/issues/1831
Once this is all done we will have a new icon in place :smile:
If it is okay for you I will let you clean up the icon files, once this is done I will merge this into the feature branch and do the necessary work to integrate the new images into the generation process and the about dialog.
hey I'll take care of it, however does the play store not have SVG support?
I see no way to edit the pull request so I'll simply create a new one
Icons with the correct background one of with is like the original icon and one with the icon used in Nextcloud https://github.com/vauvenal5/yaga/issues/87
there's a PNG version and an SVG version, The SVG version would be better to implement. And as I understand it, it has to be converted into a "Vector Drawable", This would save a lot of space and make changes to the icon much easier to do.
Some quick searching on the web got me this: https://developer.android.com/studio/write/vector-asset-studio