search

vavavr00m / boto

Automatically exported from code.google.com/p/boto
1 stars 0 forks source link

running pyflakes on boto source would clean up issues #313

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Reported on the boto-users Google Group:

Actually, it looks like someone should run pyflakes (or similar) over the
whole of the Boto source tree.  Below is what I get running pyflakes *.py
in the ec2 dir.

Terry

blockdevicemapping.py:78: undefined name 'pre'
blockdevicemapping.py:78: undefined name 'pre'
buyreservation.py:23: 'from boto.sdb.db.property import *' used; unable to
detect undefined names
buyreservation.py:23: 'from boto.sdb.db.property import *' used; unable to
detect undefined names
connection.py:27: 'xml' imported but unused
connection.py:27: 'xml' imported but unused
connection.py:30: 'config' imported but unused
connection.py:48: 'LaunchSpecification' imported but unused
connection.py:568: redefinition of fuction 'modify_image_attribute' from
line 305
connection.py:606: redefinition of fuction 'reset_image_attribute' from
line 343
connection.py:30: 'config' imported but unused
connection.py:27: 'xml' imported but unused
connection.py:30: 'config' imported but unused
connection.py:48: 'LaunchSpecification' imported but unused
connection.py:568: redefinition of fuction 'modify_image_attribute' from
line 305
connection.py:606: redefinition of fuction 'reset_image_attribute' from
line 343
connection.py:48: 'LaunchSpecification' imported but unused
connection.py:27: 'xml' imported but unused
connection.py:30: 'config' imported but unused
connection.py:48: 'LaunchSpecification' imported but unused
connection.py:568: redefinition of fuction 'modify_image_attribute' from
line 305
connection.py:606: redefinition of fuction 'reset_image_attribute' from
line 343
connection.py:568: redefinition of fuction 'modify_image_attribute' from
line 305
connection.py:27: 'xml' imported but unused
connection.py:30: 'config' imported but unused
connection.py:48: 'LaunchSpecification' imported but unused
connection.py:568: redefinition of fuction 'modify_image_attribute' from
line 305
connection.py:606: redefinition of fuction 'reset_image_attribute' from
line 343
connection.py:606: redefinition of fuction 'reset_image_attribute' from
line 343
connection.py:27: 'xml' imported but unused
connection.py:30: 'config' imported but unused
connection.py:48: 'LaunchSpecification' imported but unused
connection.py:568: redefinition of fuction 'modify_image_attribute' from
line 305
connection.py:606: redefinition of fuction 'reset_image_attribute' from
line 343
securitygroup.py:194: undefined name 'BotoClientError'
securitygroup.py:194: undefined name 'BotoClientError'
spotinstancerequest.py:43: undefined name 'code'
spotinstancerequest.py:43: undefined name 'code'
spotinstancerequest.py:45: undefined name 'message'
spotinstancerequest.py:45: undefined name 'message'
spotinstancerequest.py:43: undefined name 'code'
spotinstancerequest.py:45: undefined name 'message'

Original issue reported on code.google.com by Mitch.Ga...@gmail.com on 3 Jan 2010 at 9:10

GoogleCodeExporter commented 9 years ago 
Cleaned up the following in r1498:

s3/acl.py:23: 'StringIO' imported but unused
s3/bucket.py:25: 'ACL' imported but unused
s3/bucket.py:26: 'User' imported but unused
s3/bucket.py:154: local variable 'body' is assigned to but never used
s3/bucket.py:626: redefinition of function 'disable_logging' from line 599
s3/connection.py:26: 'types' imported but unused
s3/connection.py:234: local variable 'path' is assigned to but never used
s3/connection.py:278: local variable 'rs' is assigned to but never used
s3/key.py:30: 'config' imported but unused

Original comment by palt...@gmail.com on 22 Feb 2010 at 6:53

GoogleCodeExporter commented 9 years ago 
Cleaned up the following in r1499:

sqs/__init__.py:27: 'Queue' imported but unused
sqs/__init__.py:28: 'EncodedMHMessage' imported but unused
sqs/__init__.py:28: 'Message' imported but unused
sqs/__init__.py:28: 'MHMessage' imported but unused
sqs/connection.py:23: 'xml' imported but unused
sqs/connection.py:28: 'handler' imported but unused
sqs/connection.py:29: 'ResultSet' imported but unused
sqs/queue.py:26: 'xml' imported but unused
sqs/queue.py:28: 'SQSError' imported but unused
sqs/queue.py:29: 'XmlHandler' imported but unused
sqs/queue.py:31: 'ResultSet' imported but unused

Original comment by palt...@gmail.com on 22 Feb 2010 at 6:58

GoogleCodeExporter commented 9 years ago 
Cleaned up the following in r1500:

cloudfront/distribution.py:25: 'Signer' imported but unused

Original comment by palt...@gmail.com on 22 Feb 2010 at 7:01

GoogleCodeExporter commented 9 years ago 
Cleaned up the following in r1501:

utils.py:39: 'base64' imported but unused
utils.py:40: 'hmac' imported but unused
utils.py:43: 'imp' imported but unused
utils.py:44: 'os' imported but unused
utils.py:50: redefinition of unused 'datetime' from line 45
utils.py:227: local variable 'path' is assigned to but never used
utils.py:260: local variable 'working_dir' is assigned to but never used
utils.py:353: redefinition of unused 'smtplib' from line 49
utils.py:355: redefinition of unused 'formatdate' from line 54
utils.py:357: redefinition of unused 'formatdate' from line 355
utils.py:357: redefinition of unused 'formatdate' from line 54
utils.py:473: local variable 'olditem' is assigned to but never used

Original comment by palt...@gmail.com on 22 Feb 2010 at 7:20

GoogleCodeExporter commented 9 years ago 
Fixed unused reference to AWSConnectionError in r1502:

connection.py:53: 'AWSConnectionError' imported but unused

Original comment by palt...@gmail.com on 22 Feb 2010 at 7:22

GoogleCodeExporter commented 9 years ago 
Fixed bug in missing import in boto.exception in r1503:

exception.py:129: undefined name 'base64'

Original comment by palt...@gmail.com on 22 Feb 2010 at 7:30

GoogleCodeExporter commented 9 years ago 
Fixed bugs in fps in r1504:

fps/connection.py:27: redefinition of unused 'urllib' from line 22
fps/connection.py:86: undefined name 'respons'
fps/connection.py:108: undefined name 'respons'

Original comment by palt...@gmail.com on 22 Feb 2010 at 7:31

GoogleCodeExporter commented 9 years ago 
Fixed undefined bugs and cleaned up unused variables/imports in r1505:

manage/cmdshell.py:58: undefined name 'rawinput'
manage/cmdshell.py:146: undefined name 'subprocess'
manage/cmdshell.py:146: undefined name 'subprocess'
manage/cmdshell.py:147: undefined name 'subprocess'
manage/cmdshell.py:147: undefined name 'subprocess'
manage/propget.py:22: 'os' imported but unused
manage/propget.py:23: 'from boto.sdb.db.property import *' used; unable to 
detect 
undefined names
manage/server.py:31: 'from boto.sdb.db.property import *' used; unable to 
detect 
undefined names
manage/server.py:53: local variable 'sftp_client' is assigned to but never used
manage/server.py:530: local variable 'ssh_key_file' is assigned to but never 
used
manage/server.py:535: local variable 'ssh_key_file' is assigned to but never 
used
manage/task.py:24: 'from boto.sdb.db.property import *' used; unable to detect 
undefined names
manage/task.py:75: local variable 'need_to_run' is assigned to but never used
manage/volume.py:24: 'from boto.sdb.db.property import *' used; unable to 
detect 
undefined names
manage/volume.py:307: local variable 'e' is assigned to but never used

Original comment by palt...@gmail.com on 22 Feb 2010 at 7:49

GoogleCodeExporter commented 9 years ago 
Cleaned up boto.mapreduce in r1506

mapreduce/partitiondb.py:23: 'time' imported but unused
mapreduce/partitiondb.py:24: 'boto' imported but unused
mapreduce/partitiondb.py:26: 'from boto.sdb.persist.property import *' used; 
unable to 
detect undefined names
mapreduce/queuetools.py:2: 'sys' imported but unused

Original comment by palt...@gmail.com on 22 Feb 2010 at 7:55

GoogleCodeExporter commented 9 years ago 
Made import of StringProperty explicit in r1507 for mashups/server.py

Original comment by palt...@gmail.com on 22 Feb 2010 at 7:58

GoogleCodeExporter commented 9 years ago 
Removed unused variable in boto.mturk in r1508:

mturk/question.py:299: local variable 'xml' is assigned to but never used

Original comment by palt...@gmail.com on 22 Feb 2010 at 8:05

GoogleCodeExporter commented 9 years ago 
Fixed bugs in boto.pyami.installers and cleaned up unused imports in r1509:

pyami/bootstrap.py:22: 'pwd' imported but unused
pyami/config.py:53: local variable 'config' is assigned to but never used
pyami/launch_ami.py:25: 'get_instance_userdata' imported but unused
pyami/scriptbase.py:1: 'traceback' imported but unused
pyami/scriptbase.py:1: 'time' imported but unused
pyami/scriptbase.py:2: 'smtplib' imported but unused
pyami/startup.py:22: 'StringIO' imported but unused
pyami/startup.py:22: 'traceback' imported but unused
pyami/startup.py:22: 'os' imported but unused
pyami/startup.py:27: redefinition of unused 'find_class' from line 24
pyami/startup.py:47: local variable 'e' is assigned to but never used
pyami/installers/__init__.py:23: 'os' imported but unused
pyami/installers/__init__.py:34: undefined name 'NotImplimented'
pyami/installers/__init__.py:45: undefined name 'NotImplimented'
pyami/installers/__init__.py:51: undefined name 'NotImplimented'
pyami/installers/__init__.py:57: undefined name 'NotImplimented'
pyami/installers/__init__.py:63: undefined name 'NotImplimented'
pyami/installers/ubuntu/installer.py:95: undefined name 'NotImplimented'

Original comment by palt...@gmail.com on 22 Feb 2010 at 8:11

GoogleCodeExporter commented 9 years ago 
Fixed bug in boto.rds and cleaned up unused imports in r1510:

rds/__init__.py:23: 'xml' imported but unused
rds/__init__.py:24: 'base64' imported but unused
rds/__init__.py:25: 'time' imported but unused
rds/__init__.py:27: 'boto' imported but unused
rds/__init__.py:30: 'handler' imported but unused
rds/__init__.py:31: 'ResultSet' imported but unused
rds/__init__.py:745: undefined name 'instance_class'
rds/__init__.py:746: undefined name 'instance_class'

Original comment by palt...@gmail.com on 22 Feb 2010 at 8:14

GoogleCodeExporter commented 9 years ago 
Fixed some boto.sdb unused imports and fix some undefined bugs in r1511:

sdb/__init__.py:23: 'boto' imported but unused
sdb/connection.py:22: 'urllib' imported but unused
sdb/connection.py:25: 'boto' imported but unused
sdb/queryresultset.py:22: 'Item' imported but unused
sdb/db/blob.py:52: undefined name 'sefl'
sdb/db/model.py:23: 'from boto.sdb.db.property import *' used; unable to detect 
undefined names
sdb/db/property.py:26: 'TemporaryFile' imported but unused
sdb/db/property.py:66: local variable 'e' is assigned to but never used
sdb/db/test_db.py:2: 'from boto.sdb.db.property import *' used; unable to 
detect 
undefined names
sdb/db/test_db.py:3: 'get_manager' imported but unused
sdb/db/manager/pgmanager.py:25: 'sys' imported but unused
sdb/db/manager/pgmanager.py:26: 'from boto.exception import *' used; unable to 
detect undefined names
sdb/db/manager/sdbmanager.py:31: 'TemporaryFile' imported but unused
sdb/db/manager/xmlmanager.py:23: 'uuid' imported but unused
sdb/db/manager/xmlmanager.py:27: 'SDBPersistenceError' imported but unused
sdb/db/manager/xmlmanager.py:216: redefinition of unused 'Connection' from line 
214
sdb/persist/checker.py:23: 'boto' imported but unused
sdb/persist/object.py:24: 'from boto.sdb.persist.property import *' used; 
unable to 
detect undefined names
sdb/persist/property.py:23: 'from boto.sdb.persist.checker import *' used; 
unable to 
detect undefined names
sdb/persist/test_persist.py:2: 'from boto.sdb.persist.property import *' used; 
unable 
to detect undefined names

Original comment by palt...@gmail.com on 22 Feb 2010 at 9:33

GoogleCodeExporter commented 9 years ago 
cleaned up and fixed some bugs in r1512:

services/bs.py:24: 'ServiceMessage' imported but unused
services/message.py:22: 'boto' imported but unused
services/result.py:23: 'mimetypes' imported but unused
services/result.py:23: 'sys' imported but unused
services/result.py:23: 'time' imported but unused
services/result.py:23: 'getopt' imported but unused
services/result.py:25: 'ServiceDef' imported but unused
services/result.py:88: local variable 'mimetype' is assigned to but never used
services/result.py:114: undefined name 'key_name'
services/result.py:115: undefined name 'key_name'
services/service.py:26: 'S3ResponseError' imported but unused
services/service.py:28: 'StringIO' imported but unused
services/service.py:31: 'traceback' imported but unused
services/service.py:31: 'sys' imported but unused
services/service.py:158: local variable 'e' is assigned to but never used
services/sonofmmm.py:25: 'time' imported but unused
services/submit.py:22: 'boto' imported but unused

Original comment by palt...@gmail.com on 22 Feb 2010 at 9:41

GoogleCodeExporter commented 9 years ago 
Fixed up boto.vpc in r1513:

vpc/__init__.py:26: 'urllib' imported but unused
vpc/__init__.py:27: 'base64' imported but unused
vpc/__init__.py:28: 'boto' imported but unused
vpc/__init__.py:29: 'config' imported but unused
vpc/__init__.py:31: 'ResultSet' imported but unused
vpc/__init__.py:384: undefined name 'subnet_id'
vpc/__init__.py:400: undefined name 'dhcp_option'
vpc/__init__.py:441: undefined name 'VPNConnection'
vpc/vpnconnection.py:37: undefined name 'Nonen'

Original comment by palt...@gmail.com on 22 Feb 2010 at 9:50

GoogleCodeExporter commented 9 years ago 
Last bits cleaned up in boto.ec2.autoscale in r1514:

ec2/autoscale/__init__.py:28: 'config' imported but unused
ec2/autoscale/__init__.py:30: 'ResultSet' imported but unused
ec2/autoscale/__init__.py:31: 'RegionInfo' imported but unused
ec2/autoscale/group.py:24: 'Zone' imported but unused
ec2/autoscale/instance.py:50: undefined name 'Request'

Original comment by palt...@gmail.com on 22 Feb 2010 at 10:06

GoogleCodeExporter commented 9 years ago 
Issue 384 has been merged into this issue.

Original comment by Mitch.Ga...@gmail.com on 9 Jun 2010 at 11:23