search

vavr-io / vavr-jackson

Jackson datatype module for Vavr
Apache License 2.0
97 stars 35 forks source link

Support deserializeNullAsEmptyCollection for Maps #131

Closed sLite closed 4 years ago

sLite commented 5 years ago

Is there a reasoning or technical reason behind the fact that the MapLikeDeserializers doesn't honor deserializeNullAsEmptyCollection setting like the CollectionLikeDeserializers do?

Would you accept a PR for this, and if yes, would you prefer a new Setting deserializeNullAsEmptyMap or extend the scope of the existing one?

ruslansennov commented 5 years ago

Hi @sLite No, there is no reasoning, PR are welcome, thanks. I believe deserializeNullAsEmptyCollection is enough and we don't need a new setting flag.

sLite commented 5 years ago

Ok, thanks, i will give it a try this weekend :)

mincong-h commented 4 years ago

Hi @sLite , I implemented this feature since I saw that the issue was not active since one year. Hope you don't mind.