codecov-io commented 5 years ago

Codecov Report

Merging #137 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #137   +/-   ##
========================================
  Coverage      95.9%   95.9%           
  Complexity      281     281           
========================================
  Files            47      47           
  Lines           610     610           
  Branches        140     140           
========================================
  Hits            585     585           
  Misses           11      11           
  Partials         14      14

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f877ae...0879e3e. Read the comment docs.

mincong-h commented 4 years ago

@danieldietrich @ruslansennov should we upgrade to JUnit 5? I see Vavr Core is using JUnit 4 and therefore keeping Vavr Jackson aligned with Vavr Core is consistent. However, I think it's better to upgrade to JUnit 5 since @nstdio already did the hard work. And maybe upgrade Vavr Core to JUnit 5 after this one, too. WDYT?

ruslansennov commented 4 years ago

@mincong-h I believe that every vavr-project can be moved to JUnit5 independently

danieldietrich commented 4 years ago

Yes, I agree. We can do it independently. I already moved to JUnit 5 on the Vavr core 2.0.0 branch. I removed the AssertJ dependency there and used the JUnit 5 assertions instead. The less dependencies, the better. However, rewriting tests is a huge amount of work. You may still use AssertJ...

nstdio commented 4 years ago

Closed in favor of #146 .

vavr-io / vavr-jackson

Run tests using JUnit 5. #137

Codecov Report