vavr-io / vavr-jackson

Jackson datatype module for Vavr
Apache License 2.0
97 stars 35 forks source link

Support for building using jdk 17, Gradle wrapper upgrade to 7.6 version and Copyright update #198

Closed bmscomp closed 1 year ago

bmscomp commented 1 year ago

This pull requests aims to mainly upgrade Gradle to version 7.6 to support building the project with the new version of the wrapper and new version of java as JDK 17 and JDK 19, the pull request is widely inspired by the great job done on vavr project, there is also an update of Copyright to make it valid till the current new year 2023

ruslansennov commented 1 year ago

Hi @bmscomp @mincong-h Let's merge this PR and then I'll try to fix the credentials if need be

bmscomp commented 1 year ago

Hi @mincong-h @ruslansennov In this branch I added a publish job, but seems have an issue with credentials as in publish package step I got this error : Could not PUT 'https://oss.sonatype.org/content/repositories/snapshots/io/vavr/vavr-jackson/1.0.0-SNAPSHOT/maven-metadata.xml'. Received status code 401 from server: Unauthorized, I used to think that we need some setup for username and passport to access sonatype repository and also a signing key and secret

name: "Publish"
runs-on: ubuntu-latest
needs: [ test ]
steps:
  - uses: actions/checkout@v3
  - name: Set up Java
    uses: actions/setup-java@v3
    with:
      distribution: temurin
      java-version: 17
  - name: Publish package
    run: gradle -Prelease publishToSonatype closeAndReleaseSonatypeStagingRepository
    env:
      ORG_GRADLE_PROJECT_sonatypeUsername: ${{ secrets.SONATYPE_USER }}
      ORG_GRADLE_PROJECT_sonatypePassword: ${{ secrets.SONATYPE_PASS }}
      ORG_GRADLE_PROJECT_signingKey: ${{ secrets.SIGNING_KEY }}
      ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.SIGNING_SECRET }}
mincong-h commented 1 year ago

Hi @mincong-h @ruslansennov In this branch I added a publish job, but seems have an issue with credentials as in publish package step I got this error : Could not PUT 'https://oss.sonatype.org/content/repositories/snapshots/io/vavr/vavr-jackson/1.0.0-SNAPSHOT/maven-metadata.xml'. Received status code 401 from server: Unauthorized, I used to think that we need some setup for username and passport to access sonatype repository and also a signing key and secret

name: "Publish"
runs-on: ubuntu-latest
needs: [ test ]
steps:
  - uses: actions/checkout@v3
  - name: Set up Java
    uses: actions/setup-java@v3
    with:
      distribution: temurin
      java-version: 17
  - name: Publish package
    run: gradle -Prelease publishToSonatype closeAndReleaseSonatypeStagingRepository
    env:
      ORG_GRADLE_PROJECT_sonatypeUsername: ${{ secrets.SONATYPE_USER }}
      ORG_GRADLE_PROJECT_sonatypePassword: ${{ secrets.SONATYPE_PASS }}
      ORG_GRADLE_PROJECT_signingKey: ${{ secrets.SIGNING_KEY }}
      ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.SIGNING_SECRET }}

Ruslan will help us handle that

mincong-h commented 1 year ago

Thanks for your contribution @bmscomp !! 😁