vawser / Yapped-Rune-Bear

Personal version of Yapped for Elden Ring
284 stars 79 forks source link

Yapped is corrupting regulation.bin #34

Closed specopsbarton closed 2 years ago

specopsbarton commented 2 years ago

Hello, today I noticed a weird bug caused by yapped after saving. Even on pure regulation.bin file no matter which value I change, when in game Elden Ring gold sign used to summon npcs to fight bosses disappear, while on pure regulation.bin it is visible normally. This bug happens in my mod, but to be sure I downloaded and tested another mod and the same bug happens there. Please help.

Version of yapped: Yapped-Rune-Bear-1_09 Elden Ring version: 1.03.2 Calibrated 1.03.3 Link to my mod: https://www.nexusmods.com/eldenring/mods/159?tab=description

BurgersMcFly commented 2 years ago

Try doing Settings->Params to ignore during save and put SignPuddleParam on a clean regulation.bin file. Not home atm to test it myself unfortunately. Not sure if this param is responsible for NPC summon signs but worth a try.

specopsbarton commented 2 years ago

I tried and unfortunately this problem still happens.

specopsbarton commented 2 years ago

I tested latest update and unfortunately still this bug happens :/

BurgersMcFly commented 2 years ago

Not fixed with version 1.10. My save file if anyone wants to test it out: https://we.tl/t-XShCnri0lc

How to replicate:

Started a new game and went straight to Margit's boss fight. Summon sign before the fight is there while using a clean regulation.bin file.

Inkedeldenring_p2zulk2NrC_LI

Summon sign gone when opening and saving the regulation.bin file through Yapped. No modifications done.

eldenring_qClHXXA1b5

BurgersMcFly commented 2 years ago

Fixed by doing Settings->Param to ignore during save and added PlayRegionParam.

specopsbarton commented 2 years ago

I tested it and it works. There will be version of yapped that will fix this bug in current mods?

vawser commented 2 years ago

I've adjusted the layouts for the PlayRegionParam. Seems like there was a misalignment with the booleans. You will need to import the old data from the vanilla PlayRegionParam to fix the issue, but it should no longer wipe the boolean data.

It should look similar to this when you import the vanilla data. image

BurgersMcFly commented 2 years ago

Fixed with 1.10.1. GJ

specopsbarton commented 2 years ago

It works now thanks.