vawser / Yapped-Rune-Bear

Personal version of Yapped for Elden Ring
284 stars 79 forks source link

Incorrect Godskin set names in Paramdex #86

Open Phil25 opened 1 year ago

Phil25 commented 1 year ago

In Paramdex/ER/Names/EquipParamProtector.txt Sanguine Noble set is at ids 32*

320000 Sanguine Noble Hood
320100 Sanguine Noble Robe
320300 Sanguine Noble Waistcloth

which is ok, but its name is used for Godskin Apostle's set IDs, while Godskin Apostle's set IDs should be Godskin Noble's.

EquipParamProtector.txt:

(...)
510300 Queen's Leggings
520000 Sanguine Noble Hood
520100 Sanguine Noble Robe
520200 Sanguine Noble Bracelets
520300 Sanguine Noble Trousers
530000 Godskin Apostle Hood
530100 Godskin Apostle Robe
530200 Godskin Apostle Bracelets
530300 Godskin Apostle Trousers
540000 Depraved Perfumer Headscarf
(...)

ProtectorName.fmg.xml (1.07):

(...)
<text id="510300">Queen's Leggings</text>
<text id="520000">Godskin Apostle Hood</text>
<text id="520100">Godskin Apostle Robe</text>
<text id="520200">Godskin Apostle Bracelets</text>
<text id="520300">Godskin Apostle Trousers</text>
<text id="530000">Godskin Noble Hood</text>
<text id="530100">Godskin Noble Robe</text>
<text id="530200">Godskin Noble Bracelets</text>
<text id="530300">Godskin Noble Trousers</text>
<text id="540000">Depraved Perfumer Headscarf</text>
(...)
Phil25 commented 1 year ago

If I can toss in another naming issue here, the Magic ParamDex calls ID 5040 "[Sorcery] Death Lightning", which is an Incantation and ID 6500 "[Incantation] Night Maiden's Mist", which is a Sorcery.

All other Sorceries are before ID 6000 and after that are all other Incantations, but these 2 spells seem to be outliers.

Phil25 commented 1 year ago

Missing Paramdex entry for ID 9142 EquipParamGoods -- "About the Cave of Knowledge"