Closed radekmie closed 1 year ago
Merging #1205 (5a0a795) into master (8bb920f) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1205 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 231 231
Lines 3795 3796 +1
Branches 994 994
=======================================
+ Hits 3734 3735 +1
Misses 6 6
Partials 55 55
Impacted Files | Coverage Δ | |
---|---|---|
packages/uniforms-antd/src/HiddenField.tsx | 100.00% <ø> (ø) |
|
packages/uniforms-material/src/HiddenField.tsx | 100.00% <ø> (ø) |
|
packages/uniforms-mui/src/HiddenField.tsx | 100.00% <ø> (ø) |
|
packages/uniforms-unstyled/src/HiddenField.tsx | 100.00% <ø> (ø) |
|
packages/uniforms/src/AutoForm.tsx | 100.00% <ø> (ø) |
|
packages/uniforms/src/Bridge.ts | 100.00% <ø> (ø) |
|
packages/uniforms/src/QuickForm.tsx | 100.00% <ø> (ø) |
|
packages/uniforms/src/ValidatedForm.tsx | 100.00% <ø> (ø) |
|
packages/uniforms/src/ValidatedQuickForm.ts | 100.00% <ø> (ø) |
|
packages/uniforms/src/changedKeys.ts | 100.00% <ø> (ø) |
|
... and 32 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
In this pull request, I narrowed and improved quite a few of core uniforms types. Most notably:
model
s (in the*Form
components' props,Context
,modelTransform
, etc.) are no longer wrapped withDeepPartial
. The idea is that the form always operates on a "valid" data structure. It covers 3rd issue of #1083.Model
has to extendRecord<string, unknown>
. On the one hand it helps with object manipulation here and there, on the other that's potentially safer thanobject
. (I'm open for a different base here.)any
s tounknown
s. The only "severe" ones left are the ones in the bridges, but they deserve a separate PR (and one of them is already started in #1172).(Side note: we should switch to Zod or some other schema for our internal tests, as Simple Schema is not really TypeScript friendly.)