search

vazco / uniforms

A React library for building forms from any schema.
https://uniforms.tools
MIT License
1.94k stars 239 forks source link

Handled `min` and `max` props in Material UI and MUI (closes #1213). #1227

Closed vcardins closed 1 year ago

vcardins commented 1 year ago

Following up on the issue https://github.com/vazco/uniforms/issues/1213#issuecomment-1416058859, this PR is suppose to fix it.

radekmie commented 1 year ago

Thanks for submitting it again! Two things:

  1. It's missing this code.
  2. This PR should not touch anything else, like the Docusaurus version.
vcardins commented 1 year ago

Sorry for changing the package.json, I think I ran npm audit --fix and it caused it, reverted. Sorry, it's not clear which code is missing once the link takes me to the top of the file.

radekmie commented 1 year ago

The link I posted is the last comment of mine in the other PR (the one with the diff). And please revert the irrelevant changes, e.g., in package.json.

vcardins commented 1 year ago

I keep having issues, maybe versions related, could you try in your environment and help it to move forward? Thanks

radekmie commented 1 year ago

OK, no problem. I'll push it to your fork. (Hopefully without breaking things this time.)

codecov[bot] commented 1 year ago

Codecov Report

Merging #1227 (343b1dd) into master (482d899) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
+ Coverage   98.39%   98.42%   +0.02%     
==========================================
  Files         231      231              
  Lines        3803     3806       +3     
  Branches      998      999       +1     
==========================================
+ Hits         3742     3746       +4     
  Misses          6        6              
+ Partials       55       54       -1
Impacted Files Coverage Δ
packages/uniforms-material/src/DateField.tsx 95.65% <100.00%> (+4.74%) :arrow_up:
packages/uniforms-mui/src/DateField.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

vcardins commented 1 year ago

@radekmie @kestarumper Thank you very much! Could you give an ETA of when the changes are going to published to npm?

radekmie commented 1 year ago

I plan to do a release on Friday.

vcardins commented 1 year ago

@radekmie Apologies for asking again, but any updates on this?

radekmie commented 1 year ago

4.0.0-alpha.2 got released a couple hours ago.