Closed zendranm closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.05%. Comparing base (
c047291
) to head (946faf6
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I wonder if we should add somewhere in the docs an admonition that this theme has been deprecated. But I don't know where since there are no dedicated pages for a theme.
@kestarumper Maybe you could add it in the installation section when picking the material theme? It's probably very niche but better than nothing I suppose.
@wadamek65, but we're getting rid of the Material tab button fully (this is because we're deleting all dependencies such as styles, etc).
@kestarumper Then another option would be modifying the README in the package itself, so at least it will be shown on the npm page of the package.
@wadamek65 well, we're deleting the README too 😅. We planned to use the NPM deprecation message.
@kestarumper Then I'm out of ideas 😖
@kestarumper We can release the last version with deprecation info and then remove the package, so in the history, there will be a readme with a message.
conflict to fix
Deprecating the Material theme, as mentioned in this issue (https://github.com/vazco/uniforms/issues/1315).
skipTestIf
from test suites