vazco / uniforms

A React library for building forms from any schema.
https://uniforms.tools
MIT License
1.93k stars 239 forks source link

Deprecate `uniforms-material` theme #1338

Closed zendranm closed 1 month ago

zendranm commented 2 months ago

Deprecating the Material theme, as mentioned in this issue (https://github.com/vazco/uniforms/issues/1315).

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.05%. Comparing base (c047291) to head (946faf6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1338 +/- ## ========================================== + Coverage 94.35% 95.05% +0.69% ========================================== Files 200 175 -25 Lines 3314 2892 -422 Branches 895 763 -132 ========================================== - Hits 3127 2749 -378 + Misses 70 59 -11 + Partials 117 84 -33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kestarumper commented 1 month ago

I wonder if we should add somewhere in the docs an admonition that this theme has been deprecated. But I don't know where since there are no dedicated pages for a theme.

wadamek65 commented 1 month ago

@kestarumper Maybe you could add it in the installation section when picking the material theme? It's probably very niche but better than nothing I suppose. image

kestarumper commented 1 month ago

@wadamek65, but we're getting rid of the Material tab button fully (this is because we're deleting all dependencies such as styles, etc).

wadamek65 commented 1 month ago

@kestarumper Then another option would be modifying the README in the package itself, so at least it will be shown on the npm page of the package.

kestarumper commented 1 month ago

@wadamek65 well, we're deleting the README too 😅. We planned to use the NPM deprecation message.

wadamek65 commented 1 month ago

@kestarumper Then I'm out of ideas 😖

Monteth commented 1 month ago

@kestarumper We can release the last version with deprecation info and then remove the package, so in the history, there will be a readme with a message.

ErnestTeluk commented 1 month ago

conflict to fix