vazexqi / CodingSpectator

Watches and analyzes code edits in the Eclipse IDE non-invasively
http://codingspectator.cs.illinois.edu
Other
20 stars 14 forks source link

Refactor processor based refactorings to just rely on the ITypeRoot in the global store #224

Closed reprogrammer closed 13 years ago

reprogrammer commented 13 years ago

CodingSpectator uses an ITypeRoot to capture information about code snippets. Issue #220 made us change the ITypeRoot that CodingSpectator uses to generate the code snippet. As a result, the old ITypeRoot objects the CodingSpectator computes for every processor based refactorings are no longer needed. It's a good idea to reexamine the processor based refactorings and revert the changes that are now unnecessary. There are two advantages in getting rid of the code used to compute ITypeRoot objects in individual refactoring processors:

  1. By reverting some of the changes, the changes made by CodingSpectator become easier to understand.
  2. Making the changes of CodingSpectator to Eclipse smaller lowers the odds of changing the behavior of Eclipse and introducing bugs.