search

vazexqi / CodingSpectator

Watches and analyzes code edits in the Eclipse IDE non-invasively
http://codingspectator.cs.illinois.edu
Other
20 stars 14 forks source link

Stop rotating the error log #278

Closed reprogrammer closed 13 years ago

reprogrammer commented 13 years ago

CodingSpectator reuses Eclipse classes for capturing the exceptions. These exceptions help us in diagnosing the problems that occur in the workspace of our users. Besides, it helps us finds exceptions due to refactorings. Eclipse rotates the log when they reach a certain limit (See org.eclipse.core.runtime.adaptor.EclipseLog#checkLogFileSize). We don't lose any data because Subversion keeps the history of the error log for us. But, it would be easier to analyze the error log if doesn't get rotated. Therefore, I suggest to stop rotating the error log of CodingSpectator.

reprogrammer commented 13 years ago

I thought that the error log of participant cs-507 had got rotated. But, the rotated log file should contain the message "This is a continuation of log file" (See org.eclipse.core.runtime.adaptor.EclipseLog#checkLogFileSize). However, the error log of cs-507 does not contain a message that indicates the rotation of the log file.

reprogrammer commented 13 years ago

Since the field outFile of the instance of EclipseLog that CodingSpectator creates is null, org.eclipse.core.runtime.adaptor.EclipseLog#checkLogFileSize always returns true. Therefore, the error log of CodingSpectator should never get rotated.

reprogrammer commented 13 years ago

The default maximum size of an Eclipse log file is 1000KB (See org.eclipse.core.runtime.adaptor.EclipseLog#DEFAULT_LOG_SIZE). But, CodingSpectator has captured error logs larger than 20 MB. This confirms that the error log of CodingSpectator doesn't rotate.

reprogrammer commented 13 years ago

I'm closing this issue because it seems like we've ensured that error.log doesn't get rotated.