Makefile: Replace `CMD=/bin/sh' with `CMD /bin/sh'

vbatts / slackware-container

Minimal rootfs creation for slackware linux (ideal for container images)

https://hub.docker.com/r/vbatts/slackware

99 stars 28 forks source link

Makefile: Replace `CMD=/bin/sh' with `CMD /bin/sh' #14

Closed ardrabczyk closed 5 years ago

ardrabczyk commented 5 years ago

Docker failed with CMD=bin/sh:

$ docker import -c 'CMD=/bin/sh' slackware64-14.2.tar user/slackware:14.2 Error response from daemon: cmd=/bin/sh is not a valid change command

vbatts commented 5 years ago

bugger. It looks like an inconsistency between two tools. I've been using podman, instead of docker. https://github.com/containers/libpod/issues/4000

I'm going to need the ${CTR} logic to be smarter

vbatts commented 5 years ago

I just worked around this issue a slightly different way, and this way we don't have to wait on the upstreams to be compatible with each other. Thanks for raising the issue!