vbauerster / mpb

multi progress bar for Go cli applications
The Unlicense
2.31k stars 123 forks source link

Add I/O operation speed decorator #23

Closed xakep666 closed 6 years ago

xakep666 commented 6 years ago

Unit variants: KiB, kB, no unit Example gifs: mpb-multi mpb-single

codecov-io commented 6 years ago

Codecov Report

Merging #23 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files           8        8           
  Lines         551      551           
=======================================
  Hits          416      416           
  Misses        121      121           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25897e1...d1a3665. Read the comment docs.

vbauerster commented 6 years ago

Here I'm using speed decorator with simple speed calculation algorithm, it's not part of mpb though. What is a benefit for having speed decorator with complex calculation, like the one you propose?

xakep666 commented 6 years ago

I wanted to show instantaneous speed but your method is better because it's simple and requires only basic filtering (NaN, +-Inf). I`ll re-push comits with it.

xakep666 commented 6 years ago

@vbauerster made requested changes

vbauerster commented 6 years ago

Благодарю!