vbenjs / vben3

Next-generation Vben framework
https://vben.mufei88.com/
MIT License
556 stars 153 forks source link

🥂[demo] add workbench page example. #232

Closed Ya2gLu closed 1 year ago

Ya2gLu commented 1 year ago

General

✏️ Mark the necessary items without changing the structure of the PR template.

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

likui628 commented 1 year ago

@Ya2gLu 提交记录好复杂,能不能新建一个feat分支重新PR一下

https://github.com/vbenjs/vben3/blob/master/CONTRIBUTING.md#pr-%E6%8C%87%E5%8D%97

likui628 commented 1 year ago

看了下,界面很清新。说下几个观点:

  1. 提交记录很乱。参考下PR-指南
  2. 代码格式化,看下Prettier设置。
  3. 样式需要稍微处理下

image

Ya2gLu commented 1 year ago

好的,我重新搞一下👌