fix: form verification style fails in pop-up window

anncwb commented 2 months ago

Description

fixed #4449

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
[ ] Run the tests with pnpm test.
[ ] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

Bug Fixes
- Improved styling for form validation errors in Ant Design components, ensuring consistent border color application across different contexts.

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 0b1f522ebcea88a165e484afda7ced52e72b6ebd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes involve modifying the CSS selector for the .ant-select-selector class to ensure that form validation error styles are applied correctly within Ant Design components, particularly when used inside Modal or Drawer contexts. The parent .ant-app class has been removed from the selector, allowing the styling to be effective regardless of the component's nesting.

Changes

File	Change Summary
`packages/styles/src/antd/index.css`	Modified CSS selector from `.ant-app .form-valid-error .ant-select-selector` to `.form-valid-error .ant-select-selector` to ensure styling applies outside `.ant-app`.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure validation error styles are applied in Modal/Drawer (#4449)	✅

Possibly related PRs

#4407: Modifies CSS for the .ant-select-selector class, relevant to the styling changes in this PR.
#4442: Introduces default validation rules for selector components, which may interact with the styling changes.
#4444: Addresses default required label style for select components, relevant to form validation representation.
#4446: Enhances focus style for input boxes during validation failures, aligning with the main PR's focus.

Suggested reviewers

vince292007

Poem

🐇 In the garden of code, changes bloom bright,
Styles for errors now shine with delight.
No more lost borders in drawers so neat,
With CSS magic, our forms are complete!
Hooray for the fixes, let’s hop with glee,
For validation's now clear, as clear as can be! 🌼

Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

Commits

Files that changed from the base of the PR and between 37645f08be4dafe78c7f04a998dd1a6d18d82153 and 0b1f522ebcea88a165e484afda7ced52e72b6ebd.

Files selected for processing (1)

* packages/styles/src/antd/index.css (1 hunks)

Additional comments not posted (1)

packages/styles/src/antd/index.css (1)
`15-17`: **LGTM! The CSS selector change fixes the validation error styling issue.** The removal of the `.ant-app` parent class from the selector ensures that the validation error styles are applied consistently to the `.ant-select-selector` element within the `.form-valid-error` context, regardless of whether it is inside an `.ant-app` node or not. This change addresses the reported issue where the validation error styles were lost when Ant Design components like Select were used within Modal or Drawer components. By removing the dependency on the `.ant-app` parent class, the styles will now be applied correctly in these scenarios, providing a consistent user experience for form validation feedback across different UI contexts. Great work on identifying and fixing this styling issue! The change aligns with the PR objectives and improves the overall usability of the form components.

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

vbenjs / vue-vben-admin