Closed anncwb closed 1 week ago
Latest commit: 30bfdeb8017a4b66c83a8f830cf02276e6c91743
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
[!WARNING]
Rate limit exceeded
@anncwb has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 15 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 03db941330be1b3a528a4a1cc1d35d2ddafe97b4 and 30bfdeb8017a4b66c83a8f830cf02276e6c91743.
The pull request introduces a new updateSchema
method to the FormApi
class, allowing dynamic updates to form schemas based on partial updates. It enhances the test coverage for this method and modifies a form component to utilize a Select
component instead of an Input
. The changes aim to improve the interactivity and flexibility of form management within the application.
Files | Change Summary |
---|---|
packages/@core/ui-kit/form-ui/__tests__/form-api.test.ts |
Added a test suite for the updateSchema method with various test cases for validation. |
packages/@core/ui-kit/form-ui/src/form-api.ts |
Introduced the updateSchema method to update form schema dynamically based on partial data. |
playground/src/views/examples/form/api.vue |
Replaced Input with Select , updated field names and labels, and added schema update case. |
sequenceDiagram
participant User
participant FormApi
participant FormComponent
User->>FormComponent: Click update button
FormComponent->>FormApi: Call updateSchema with new options
FormApi->>FormApi: Validate new schema
alt Valid schema
FormApi->>FormApi: Update schema state
FormApi->>FormComponent: Notify schema updated
else Invalid schema
FormApi->>FormApi: Log error
end
Objective | Addressed | Explanation |
---|---|---|
Open an interface to modify all properties of a form field (#[4447]) | ✅ |
Props
interface and computedSchema
structure, potentially improving how form components handle schema updates.In a meadow of forms, where rabbits play,
A new schema method brightens the day.
With selects that change, and options that flow,
Our forms are now lively, with much more to show!
Hop, hop, hooray for updates so grand,
In the world of form APIs, we take a stand! 🐰✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
close #4447
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit
New Features
updateSchema
method for dynamic updates to form schemas.Input
component with aSelect
component, enhancing user interaction with new options.Bug Fixes
Tests
updateSchema
method, validating correct updates and error logging.