vberlier / mudkip

A friendly Sphinx wrapper.
https://vberlier.github.io/mudkip/
MIT License
9 stars 2 forks source link

`pygments_dark_style` and maybe other theme options fail #234

Open RitikShah opened 1 year ago

RitikShah commented 1 year ago

It seems to me that setting some values for the override (aka the conf.py file) don't override theme set options. Example:

[tool.mudkip]
preset = "furo"
title = "my-epic-docs"

[tool.mudkip.override]
...
pygments_style = "material"

Here, I wish to change the code highlighting style for pygments to material as furo uses a different theme. Removing preset = "furo" enables for my code highlighting theme to work while enabling furo causes my option to effectively get ignored. It seems to me that my overrides get set first, and then the furo preset gets set, but I can't be too certain.

Edit: furo has pygments_dark_style but it seems to me that mudkip isn't recognizing or letting sphinx recognize this field based on how the config is getting parsed or something.

RitikShah commented 1 year ago

Nevermind, this might be a furo specific bug w/ how dark and light mode have different syntaxes...

RitikShah commented 1 year ago

https://pradyunsg.me/furo/customisation/colors/#code-block-styling Yup, just missed this part of the docs, false alarm!

RitikShah commented 1 year ago

WARNING: unknown config value 'pygments_dark_style' in override, ignoring Potentially, mudkip isn't recognizing certain theme specific options..