search

vbhayden / unity-xapi-wrapper

Library for interacting with an LRS from within a Unity project.
MIT License
4 stars 7 forks source link

JSON.net Assemblies file appears to be missing #2

Open jyearley opened 3 years ago

jyearley commented 3 years ago

The Readme mentions that an asset package had been included (and a "JSON.Net Assemblies" file) in the project to extract the needed JSON.net version, though that file appears to not be included.

Realize that this repo has moved into the ADL account, though that repo doesn't have an "Issues" tab on it, and it didn't appear to have the asset package or file either.

Giantbean commented 2 years ago

Still no "JSON.Net Assemblies" file here or in the forked ADL account with no issue tracker. Please advise.

vbhayden commented 2 years ago

Misread the issue initially and assumed it was talking about an asmdef, checking now for where the unity package ended up.

vbhayden commented 2 years ago

@jyearley thanks for bringing this up, sorry for the delay + misread @Giantbean thanks for the bump

Should be fixed in with https://github.com/vbhayden/unity-xapi-wrapper/pull/3

Giantbean commented 2 years ago

Thank you this now gives errors

Assets\Unity-xAPI-Wrapper-master\Editor\ConfigObjectInspector.cs(35,29): error CS1501: No overload for method 'Space' takes 1 arguments

This pops up 4 times in the ConfigObjectInspector.cs

Edit: GUILayout.Space(20); will add 20 pixels but for EditorGUILayout.Space(); the pixels should be predefined. Will removing the "Editor" be an issue here?

Edit 2: Tested removing the "Editor" or the "20" form EditorGUILayout.Space(20); and I have many missing Mono Behaviors in the Buttons Demo either way?

vbhayden commented 2 years ago

Looks like there were a few issues with the .meta files, I'll look at this after work.

Giantbean commented 2 years ago

Did you get the meta files sorted out? Should I open a new issue for these compile errors and broken meta data?

vbhayden commented 2 years ago

Afternoon guys,

The example and whatnot should all be resolved + merged now. Last week ended up being a bit longer than expected, so I didn't have much mental bandwidth during off-hours.

For the example, I checked and things seem to be working fine now -- even with newer versions of Unity apparently importing Newtonsoft's JSON library automatically.

Let me know if anything else seems odd.

Giantbean commented 2 years ago

I'm still getting Assets\Unity-xAPI-Wrapper-master\Editor\ConfigObjectInspector.cs(35,29): error CS1501: No overload for method 'Space' takes 1 arguments in older versions of Unity but not in a 2020 version. Any suggestion for use with Unity 2018 to add xAPI to an old project?

vbhayden commented 2 years ago

Whoops forgot that the Space thing was an issue, should be fixed now

https://github.com/vbhayden/unity-xapi-wrapper/commit/c210e07ce44bc1be842def07a3873e9c02cbfd3d

Giantbean commented 2 years ago

I had to rebuild the buttons in 2018 but I Got it working! Thank you so much! I would say the issue can be closed.

jyearley commented 11 months ago

Hey there! Would you be able to merge this project with the ADL project? [https://github.com/adlnet/Unity-xAPI-Wrapper] That is the project that I refer others to when sharing with others interested in xAPI reporting to an LRS and using Unity. As it's the one that's the most straightforward, and a part of ADL. And it reads "This branch is 5 commits behind vbhayden:master."

Thank you for reading, keeping the project updated, and understanding!