Allow to build without MySQL Database

vbkunin / itop-docker

Combodo iTop docker image

https://hub.docker.com/r/vbkunin/itop/

MIT License

92 stars 51 forks source link

Allow to build without MySQL Database #12

Closed kboenke closed 5 years ago

kboenke commented 5 years ago

Implemented several options in Dockerfile:

HEALTHCHECK - using curl, check every 5 minutes if the webserver is still reachable
ENTRYPOINT - instead of CMD to start service
ARG NO_DATABASE - can be used to build an image without a local MySQL installation
ENV no_database - to store the build-argument from ARG

Changed run.sh to accommodate these changes; don't try to start MySQL if it has not been installed.

kboenke commented 5 years ago

Sorry about the many submits - should use the Webinterface to implement stuff. ;-)

vbkunin commented 5 years ago

Hi @kboenke ! Thanks for your contributing! I'm going to add a separate tag for the image without MySQL. I think it's easier to maintain and more in Docker-style. I'll add HEALTHCHECK and ENTRYPOINT as soon as I found the way to merge just those commits😀.

vbkunin commented 5 years ago

Added HEALTHCHECK and ENTRYPOINT, thanks!