vblanco20-1 / vkguide-comments

Storage for the comments of vulkan-guide
0 stars 0 forks source link

Imgui Implementation Comments #12

Open utterances-bot opened 3 years ago

utterances-bot commented 3 years ago

Implementing DearImgui to a Vulkan engine - Vulkan Guide

Practical guide to vulkan graphics programming

https://www.vkguide.dev/docs/extra-chapter/implementing_imgui/

Harold2017 commented 3 years ago

Should use lastest ImGUI version to avoid strange 'Validation Error: [ VUID-VkMappedMemoryRange-size-01389 ]', please refer to this.

CarloWood commented 2 years ago

This says to use in target_sources the files "${CMAKE_CURRENT_SOURCE_DIR}/imgui/imgui_impl_vulkan.cpp" and "${CMAKE_CURRENT_SOURCE_DIR}/imgui/imgui_impl_sdl.cpp". With the current imgui that should be "${CMAKE_CURRENT_SOURCE_DIR}/imgui/backends/imgui_impl_vulkan.cpp" and "${CMAKE_CURRENT_SOURCE_DIR}/imgui/backends/imgui_impl_sdl.cpp".

CarloWood commented 2 years ago

Also, "${CMAKE_CURRENT_SOURCE_DIR}/imgui/imgui_tables.cpp" is missing.

jonathan-hopkins commented 2 years ago

The CVAR page is missing a comment section. The CVarArray destructor uses the wrong delete, it should be: delete[] cvars;

tuket commented 1 year ago

Hello, Victor Blanco. I have checked the code repo, but it looks like ImGui is not used there. Any chance you could upload that example code as well? I'm having trouble to get gamma color spaces right with ImGui, and I would like to see how you did it. Thanks!

EDIT: To anyone struggling to get gamma correction working with Vulkan+ImGui: https://tuket.github.io/posts/2022-11-24-imgui-gamma/

alexpanter commented 1 year ago

What are the steps involved when using something other than SDL?

Kaninchen221 commented 1 year ago

I used to this guide to integrate imgui with my vulkan/glfw renderer and the steps are nearly the same

JordanLiao commented 10 months ago

is Dear ImGui compatible with VK_EXT_DESCRIPTOR_BUFFER as of now?