vbmithr / ocaml-websocket

Websocket library for OCaml
ISC License
161 stars 44 forks source link

cohttp_lwt: fix bug with not calling conn_closed on fd close. #112

Closed NightBlues closed 4 years ago

NightBlues commented 4 years ago

When client closes tcp connection its left in CLOSE_WAIT state. https://github.com/mirage/ocaml-cohttp/blob/master/cohttp-lwt/src/server.ml#L141 Because io_handler only stops when send_frames stops too. So conn_closed in cohttp-lwt is not called.