search

vbmithr / ocaml-websocket

Websocket library for OCaml
ISC License
162 stars 44 forks source link

Make Conduit_lwt_unix.serve call compatible with newer conduit #114

Closed tizoc closed 4 years ago

tizoc commented 4 years ago

I tried to install this from opam but it tried to force me to downgrade cohttp-lwt-unix and conduit-lwt-unix (see https://github.com/ocaml/opam-repository/pull/14693/files#diff-7f11cf70449495b0ed8dc68f0027e33fR20)

What changed in conduit: https://github.com/mirage/ocaml-conduit/commit/07a1925fc4ff50e5ee7e04afab5f3fb63f22927d#diff-7cb62769efef1a71cd4eb0ec32d355fe

The reason it is not compatible as-is is that the new version of conduit makes the on_exn argument mandatory.

This patch fixes that without changing this library's API.