Closing client connections

paurkedal commented 2 years ago

Websocket_lwt_unix.with_connection does not provide a way of closing the socket after the session terminates. I'm using 2.14 but checked also the current definition in the master branch. Assuming you agree, what would be the best way of fixing it?

Changing the returned pair of functions into a triple, the last being a close function, would be in line with the current design, but would break backwards compatibility.
Automatically closing when encountering a close frame to keep the current interface? In this case, if the server closes, should the connection be closed, or should the client respond with a close?
Adding an abstract type for the connection with corresponding send, receive, and close functions.

vbmithr commented 2 years ago

Actually, I now use a different (pure Async) library to do my websockets so I have to admit that I’m not maintaining this one anymore (and I would probably re-write everything!). Let me have a look and I’ll give you my take on the matter :)

See #126

vbmithr commented 1 year ago

Closed via https://github.com/vbmithr/ocaml-websocket/commit/1788438561521c71f8a2cfb93d8c7264f06ef6ec. Please reopen if there is still an issue here.

vbmithr / ocaml-websocket

Closing client connections #125