Compilation error

[IgorLiner]

Any idea if lwt API was changed? I can't compile ocaml-websocket:

• ocamlfind ocamlc -c -g -annot -package lwt.syntax -package lwt -package cryptokit -package cohttp.lwt -package bitstring.syntax -package bitstring -syntax camlp4o -I lib -o lib/websocket.cmo lib/websocket.ml File "lib/websocket.ml", line 202, characters 29-42: Error: The function applied to this argument has type ?buffer_size:int -> (Lwt_io.input_channel * Lwt_io.output_channel) Lwt.t This argument cannot be applied with label ~setup_socket Command exited with code 2. Compilation unsuccessful after building 4 targets (3 cached) in 00:00:01. E: Failure("Command ''/home/dev/.opam/4.00.1/bin/ocamlbuild' lib/websocket.cma lib/websocket.cmxa lib/websocket.a lib/websocket.cmxs tests/wscat.native -tag debug' terminated with error code 10") make: *\ [build] Error 1

Any help would be appreciated.

[vbmithr]

My bad. I was using a special customized version of lwt (just a minor change) that never went upstream. I’m fixing that ASAP. Since people are interested I’m probably going to release this lib on OPAM!

[IgorLiner]

Thanks. Can you point me to the change? Can i apply this patch to lwt manually?

[vbmithr]

On 12/03/2013 18:16, IgorLiner wrote:

Thanks. Can you point me to the change? Can i apply this patch to lwt manually?

Yes. Either you use the branch "fix_compilation" (that fixes compilation, but that does not work correctly because I was using patched lwt to be ale to

let setup_socket fd = Lwt_unix.setsockopt fd Lwt_unix.TCP_NODELAY true

On the socket that is going to be used for the connection (websocket needs TCP_NODELAY).

Or you use my @vbmithr/lwt branch

(you can install it with opam by doing "opam pin git://")

I have to fix this anyway, I’ll do it soon. The correct thing to do is to not use Lwt_io.{open_connection,establish_server} but reimplementing them by a version that do the TCP_NODELAY.

Cheers

[IgorLiner]

Thanks, i'm currently using @vbmithr/lwt. Works great.